Conversation
| @@ -0,0 +1,3 @@ | |||
| #pragma once | |||
|
|
|||
| void Bar() {} | |||
There was a problem hiding this comment.
warning: function 'Bar' defined in a header file; function definitions in header files can lead to ODR violations [misc-definitions-in-headers]
void Bar() {}
^Additional context
sandbox/template/src/foo.hpp:2: make as 'inline'
void Bar() {}
^| @@ -1,3 +1,26 @@ | |||
| #include <bits/atomic_wait.h> | |||
| #include <iostream> | |||
There was a problem hiding this comment.
warning: included header atomic_wait.h is not used directly [misc-include-cleaner]
| #include <iostream> | |
| #include <iostream> |
|
|
||
| std::cout << sum << '\n'; | ||
|
|
||
| utils::IntArray adda; |
There was a problem hiding this comment.
warning: call to deleted constructor of 'utils::IntArray' [clang-diagnostic-error]
utils::IntArray adda;
^Additional context
sandbox/template/src/utils.hpp:16: 'IntArray' has been explicitly marked deleted here
IntArray() = delete;
^| std::cout << sum << '\n'; | ||
|
|
||
| utils::IntArray adda; | ||
| utils::IntArray b(1, 1); |
There was a problem hiding this comment.
warning: variable 'b' of type 'utils::IntArray' can be declared 'const' [misc-const-correctness]
| utils::IntArray b(1, 1); | |
| utils::IntArray const b(1, 1); |
| utils::IntArray adda; | ||
| utils::IntArray b(1, 1); | ||
|
|
||
| { utils::IntArray a; } |
There was a problem hiding this comment.
warning: call to deleted constructor of 'utils::IntArray' [clang-diagnostic-error]
{ utils::IntArray a; }
^Additional context
sandbox/template/src/utils.hpp:16: 'IntArray' has been explicitly marked deleted here
IntArray() = delete;
^| public: | ||
| Foo() { std::cout << "Foo()\n"; } | ||
| Foo(int) { std::cout << "Foo(int)\n"; } | ||
| Foo(const std::string &s) { std::cout << s << "(string)\n"; } |
There was a problem hiding this comment.
warning: no header providing "std::string" is directly included [misc-include-cleaner]
sandbox/template/src/utils.hpp:3:
+ #include <string>| @@ -0,0 +1,3 @@ | |||
| #include "sum.hpp" | |||
|
|
|||
| int Sum(int first_number, int second_number, int third_number) { return 6; } No newline at end of file | |||
There was a problem hiding this comment.
warning: parameter 'first_number' is unused [misc-unused-parameters]
| int Sum(int first_number, int second_number, int third_number) { return 6; } | |
| int Sum(int /*first_number*/, int second_number, int third_number) { return 6; } |
| @@ -0,0 +1,3 @@ | |||
| #include "sum.hpp" | |||
|
|
|||
| int Sum(int first_number, int second_number, int third_number) { return 6; } No newline at end of file | |||
There was a problem hiding this comment.
warning: parameter 'second_number' is unused [misc-unused-parameters]
| int Sum(int first_number, int second_number, int third_number) { return 6; } | |
| int Sum(int first_number, int /*second_number*/, int third_number) { return 6; } |
| @@ -0,0 +1,3 @@ | |||
| #include "sum.hpp" | |||
|
|
|||
| int Sum(int first_number, int second_number, int third_number) { return 6; } No newline at end of file | |||
There was a problem hiding this comment.
warning: parameter 'third_number' is unused [misc-unused-parameters]
| int Sum(int first_number, int second_number, int third_number) { return 6; } | |
| int Sum(int first_number, int second_number, int /*third_number*/) { return 6; } |
| @@ -0,0 +1,3 @@ | |||
| #include <iostream> | |||
|
|
|||
There was a problem hiding this comment.
warning: included header iostream is not used directly [misc-include-cleaner]
No description provided.